Packing fixes (supersedes my previous packing fix patch)

Dmitry Timoshkov dmitry at baikal.ru
Mon May 3 07:05:17 CDT 2004


"Hans Leidekker" <hans at it.vu.nl> wrote:

> This time I tried to be exhaustive. I used the following algorithm
> to find all structures that need 8 byte alignment:
> 
>   find all types typedef:ed to __int64
>   find all structures embedding any of the types found
>   REPEAT
>     find all types typedef:ed to any of the structures found
>     find all structures embedding any of the structures or types found
>   UNTIL no new types or structures are found
> 
> This patch includes changes to .idl files as well as to the 
> corresponding .h files. Is that OK? Or should I remove changes 
> to .h files?

I think that a correct way deciding whether a struct is correctly
packed is to make sure that our generated tests for packing issues
work under MSVC, then just compare the results. Otherwise we risk
to miss something.

-- 
Dmitry.




More information about the wine-devel mailing list