Fix For Menu Bar (resend)
William Poetra Yoga H
williampoetra at yahoo.com
Wed Nov 10 06:47:15 CST 2004
--- Alexandre Julliard <julliard at winehq.org> wrote:
> William Poetra Yoga H <williampoetra at yahoo.com> writes:
> > Index: dlls/user/menu.c
> > ===================================================================
> > RCS file: /home/wine/wine/dlls/user/menu.c,v
> > retrieving revision 1.8
> > diff -u -r1.8 menu.c
> > --- dlls/user/menu.c 8 Nov 2004 22:12:42 -0000 1.8
> > +++ dlls/user/menu.c 9 Nov 2004 14:26:09 -0000
> > @@ -1441,8 +1441,6 @@
> > if (lppop->Height == 0)
> > MENU_MenuBarCalcSize(hDC, lprect, lppop, hwnd);
> > - lprect->bottom = lprect->top + lppop->Height;
> > -
> This doesn't look right at all, you cannot simply ignore the computed
> size of the menu bar, this is going to break owner drawn menus.
> Alexandre Julliard
> julliard at winehq.org
Oops... sorry... I overlooked the "if (lppop->Height == 0)" part... I fixed
lprect->bottom in MENU_MenuBarCalcSize(), and assumed that lprect->bottom will
always be correct... I'll fix the patch and resend it tomorrow.
Btw, can a person other than the one who made patch edit the patch and resubmit
it? I mean, if I wrote a patch with an error in it, then can someone take the
patch, fix the error, and resubmit it? Or, if you find an error (such as in
this case), can you (as the one who has full access to the cvs repository) take
my patch, fix it, and commit it?
I know this sounds a bit unethical (maybe impolite would be a better word), but
for practical reasons I think this is permittable. Or maybe I should
specifically state (at wine-patches) that I "allow anyone else to fix the patch
should it contain errors, and resubmit it"?
Do you Yahoo!?
Check out the new Yahoo! Front Page.
More information about the wine-devel