taskmodal messagebox implementation, take 3

Juan Lang juan_lang at yahoo.com
Sat Nov 13 23:20:23 CST 2004


Ivan, a couple comments on this.

You wrote:
+BOOL CALLBACK MSGBOX_EnumProc(HWND hwnd, LPARAM lParam)
+{
+    static int counter1, counter2, heapcheck=0;
+    static HWND *handles;

static variables aren't thread safe.  Two threads attempting to do task
modal dialogs (yes, this is probably strange) could result in weird
failures.

+                 handles=(HWND*)malloc(counter1*sizeof(HWND));

Any reason you aren't using HeapAlloc instead?

--Juan


		
__________________________________ 
Do you Yahoo!? 
Check out the new Yahoo! Front Page. 
www.yahoo.com 
 




More information about the wine-devel mailing list