icmstream mem leak fix

Mike McCormack mike at codeweavers.com
Tue Nov 30 01:07:18 CST 2004

Hi James,

That looks kind of wrong, both the before and after...
Interfaces should be released, not free'd...

Secondly, freeing the interface if the Query works is almost definitely 
wrong, because ppv will likely point to the same memory as pstream.


James Hawkins wrote:

>    hr = IAVIStream_QueryInterface((IAVIStream*)pstream, riid, ppv);
> -  if (FAILED(hr))
> -    LocalFree((HLOCAL)pstream);
> +
> +  LocalFree((HLOCAL)pstream);
>    return hr;
>  }

More information about the wine-devel mailing list