Re-implement MSVCRT *printf

Mike McCormack mike at codeweavers.com
Tue Oct 26 22:02:25 CDT 2004


Aneurin Price wrote:
> Comments, anyone?

Looks like you've put quite a bit of effort into that. I think it's a 
worthwhile effort, however, please consider:

* using a style more consistent with the rest of the Wine codebase
* not abusing the preprocessor in printf.h,
* not writing C code in the header in printf.h
* preventing code duplication by implementing the A functions using the 
W functions
* writing some regression tests to show your code is correct

thanks,

Mike



More information about the wine-devel mailing list