Shwapi updates

Jon Griffiths jon_p_griffiths at yahoo.com
Mon Sep 13 04:38:14 CDT 2004


Hi James,

> Can this patch be broken up into smaller, independent parts?  It's
> more likely to be committed if that is the case.

Aside from the tests, what constitutes independent? These are all new
functions so there is no possibility of regressions, which is the
main reason to split up patches. Ease of understanding/reviewing the
patches is the other main reason, but each function is only 5-10
lines.

Since each added function requires the spec file to be updated its
much easier to add the functions together (It helps me clean up the
diffs from my tree to wine-cvs faster too).

Cheers,
Jon


=====
"Don't wait for the seas to part, or messiahs to come;
 Don't you sit around and waste this chance..." - Live

jon_p_griffiths at yahoo.com


		
_______________________________
Do you Yahoo!?
Shop for Back-to-School deals on Yahoo! Shopping.
http://shopping.yahoo.com/backtoschool



More information about the wine-devel mailing list