Shwapi updates

James Hawkins truiken at
Mon Sep 13 13:19:46 CDT 2004

> Aside from the tests, what constitutes independent?

If the functions do not rely on each other, then they are independent
of each other.  You can leave it the way it is, but it was a
suggestion to help from the case where say one of the functions has an
error in it.  If that is the case then none of th patch is committed
where if it was split into seperate patches, 4/5 would be committed
and only a minor change is required to finish it, but this is all
preference of author/reviewer.

On Mon, 13 Sep 2004 02:38:14 -0700 (PDT), Jon Griffiths
<jon_p_griffiths at> wrote:
> Hi James,
> > Can this patch be broken up into smaller, independent parts?  It's
> > more likely to be committed if that is the case.
> Aside from the tests, what constitutes independent? These are all new
> functions so there is no possibility of regressions, which is the
> main reason to split up patches. Ease of understanding/reviewing the
> patches is the other main reason, but each function is only 5-10
> lines.
> Since each added function requires the spec file to be updated its
> much easier to add the functions together (It helps me clean up the
> diffs from my tree to wine-cvs faster too).
> Cheers,
> Jon
> =====
> "Don't wait for the seas to part, or messiahs to come;
> Don't you sit around and waste this chance..." - Live
> jon_p_griffiths at
> _______________________________
> Do you Yahoo!?
> Shop for Back-to-School deals on Yahoo! Shopping.

James Hawkins

More information about the wine-devel mailing list