dib fixes

Rein Klazes wijn at wanadoo.nl
Fri Apr 8 07:47:17 CDT 2005

Hi Eric,

I am looking into a couple of crashes in dlls/x11drv/dib.c caused by a
patch from you. The patch (attached) is only 5 years old, I am sure you
remember all the details ;)

To be precise, I get X-errors in the calls to XGetSubImage caused by out
of range parameters. Fixing this by some parameter checking is not the
big problem, but I wonder if it is still necessary to have those calls

You call it a "quick hack", would it not be better to remove it now and
properly fix any problems that may surface? The patch that I sent in
yesterday ( "fix decoding compressed dibs") is an example of such

-------------- next part --------------
An embedded message was scrubbed...
From: Eric Pouech <Eric.Pouech at wanadoo.fr>
Subject: dib fixes
Date: Sun, 03 Oct 1999 20:28:25 +0000
Size: 8336
Url: http://www.winehq.org/pipermail/wine-devel/attachments/20050408/e432d313/attachment.mht

More information about the wine-devel mailing list