stubbed powrprof.dll
Benjamin Cutler
cutler at cs.colostate.edu
Sat Apr 9 23:47:42 CDT 2005
Mike McCormack wrote:
>
> You don't need to diff configure, only configure.ac
>
> You can probably omit dlls/Makefile.in too, as it is also automatically
> generated (by make_dlls).
>
Alright, I'll take these out of the next diff.
>
> Most of the Wine headers use the prefix __WINE_ -> __WINE_POWRPROF_H
>
Fixed.
>
> Don't include other headers in your header unless the Windows Platform
> SDK does it (it doesn't in this case). We would like the header
> dependencies to be the same as the Platform SDK, so programs can compile
> the same way.
>
Hmm, ok. I'll have to make some changes to the .c file then. Thanks for
pointing this out.
>
> These are defined in winnt.h. You need to patch that, not add it to your
> new file. You shouldn't add comments for all these things unless
> there's some trick to them.
>
>> +/* FIXME: These enums belong in winnt.h */
>
>
> Yes. Is there any reason you didn't fix it?
>
> So have a go at patching all the headers first, and then after the
> header patches are accepted, try submitting the dll implementation.
> Smaller patches are easier to get accepted.
>
> Mike
>
>
>
Is there some way that winnt.h is organized, or can I just throw them in
at the end? That header file is gigantic so I can't tell if it's
supposed to be organized in some particular way.
More information about the wine-devel
mailing list