Protect included headers with the proper autoconf macros

Jacek Caban jack at itma.pwr.wroc.pl
Wed Aug 10 03:19:08 CDT 2005


Hello.

Vincent Béron wrote:

>Changelog:
>Protect headers with proper autoconf macros.
>
>Vincent
>  
>
>------------------------------------------------------------------------
>
>Index: dlls/msxml3/msxml_private.h
>===================================================================
>RCS file: /home/wine/wine/dlls/msxml3/msxml_private.h,v
>retrieving revision 1.5
>diff -u -p -r1.5 msxml_private.h
>--- dlls/msxml3/msxml_private.h	9 Aug 2005 11:17:47 -0000	1.5
>+++ dlls/msxml3/msxml_private.h	9 Aug 2005 21:56:24 -0000
>@@ -23,9 +23,11 @@
> 
> #include "xmldom.h"
> 
>-#ifdef HAVE_LIBXML2
>-
>+#ifdef HAVE_LIBXML_PARSER_H
> #include <libxml/parser.h>
>+#endif
>+
>+#ifdef HAVE_LIBXML2
> 
> extern HRESULT DOMElement_create( IXMLDOMElement** DOMElement, xmlDocPtr xmldoc );
> extern HRESULT NodeMap_create(IXMLDOMNamedNodeMap** DomNamedNodeMap, xmlDocPtr xmldoc, xmlNodePtr node );
>  
>

This patch causes the compile error for me. I have libxml2 headers
but I don't have a library. XML2INCL is defined only if the configure
script found library so gcc cannot find my headers at compile time.
If you want to change it, you'll have to change configure.ac as well,
but why do you want to include libxml if it won't be used anyway?

Jacek



More information about the wine-devel mailing list