WINEALSA: comment on unexpected shrinking of mmap-buffer (resend)

Alex Villací­s Lasso a_villacis at palosanto.com
Mon Aug 29 12:44:36 CDT 2005


Robert Reif wrote:

> Alex Villací­s Lasso wrote:
>
>> The first test that fails with the ALSA driver is the so-called 
>> "reference" tone, which, as far as I could see, is played with a 
>> primary buffer, and no secondary buffer. The reference tone uses the 
>> hardware position directly, which wraps around at a buffer size that 
>> changes unexpectedly when switching playback formats. I have prepared 
>> a patch that "fixes" this, by re-querying the buffer size in the case 
>> of a primary buffer, and displaying a warning if it detects a buffer 
>> size change. However, I don't know if the buffer size is supposed to 
>> remain constant across buffer format changes. If it does, then the 
>> patch would need to be modified to mark this as a TODO.
>
>
> Fix the wine ALSA driver rather than the test unless you can prove 
> that the test fails on Windows.
>
This is a modified patch that marks the problematic buffer resize as a 
todo_wine. Could somebody please test this patch and confirm that the 
buffer size actually remains constant across playback format changes?


-------------- next part --------------
A non-text attachment was scrubbed...
Name: wine-dsound-test-todo.patch
Type: text/x-patch
Size: 4464 bytes
Desc: not available
Url : http://www.winehq.org/pipermail/wine-devel/attachments/20050829/9a4c79c7/wine-dsound-test-todo.bin


More information about the wine-devel mailing list