ddraw: make some driver info not const
lionel.ulmer at free.fr
Sat Dec 3 02:44:07 CST 2005
On Fri, Dec 02, 2005 at 12:11:34PM -0700, Vitaliy Margolen wrote:
> Friday, December 2, 2005, 11:46:39 AM, Rein Klazes wrote:
> > Hi,
> > Making this information not const makes the application proceed further.
> > Changelog:
> > dlls/ddraw : ddraw_hal.c, ddraw_user.c
> > Make some driver info not const, some applications want to modify it.
> This is wrong. No user program should modify our internal data. I think
> you need to copy this data into heap before passing it to the app. You
> should make simple test to check if the data returned on windows is
> within heap or not.
Yeah, I agree with Vitaliy here... We were alread hit multiple times by this
bug in other cases: Wine should never send to the application actual private
data as many games expect to use these values to do actual processing.
Lionel Ulmer - http://www.bbrox.org/
More information about the wine-devel