LoadImage (4bpp) / CopyImage() crashing

Cyril Margorin comargo at gmail.com
Fri Dec 9 16:58:35 CST 2005

the second email was send with patched created using such command:
cvs diff -u dlls/user/cursoricon.c > user_cursoricon_copyimage.patch
Is it correct? (I'm sorry, my cvs experience is not big enough). Also
I added 'diff -u' line to my .cvsrc file.

According to CreateDCW function - this block was looked up from same
file. It uses static variable screen_dc....
But may be you are right, GetDC(0) should be used.

2005/12/10, Vitaliy Margolen <wine-devel at kievinfo.com>:
> Friday, December 9, 2005, 3:12:23 PM, Cyril Margorin wrote:
> > Hello,
> > Could anyone tell me, why function CopyImage uses
> > GetBitmapBits/SetBitmapBits, while MSDN marks these function as
> > absolete?
> Because what MSDN says doesn't really mean it's the same on Wine. But my
> guess would be that it's been implemented that way and no one changed it.
> > I've tried to move from GetBitmapBits/SetBitmapBits to
> > GetDIBits/SetDIBits. It seems to me that this way is correct, if keep
> > in mind, that GetBitmapBits is wrong.
> >
> > In attachment you may find a patch for it.
> Please use unified format from the to of the tree. (looks like you beat
> me to it).
> But your patch looks like 10x more then what was there before.
> Also you are using CreateDCW which a really heavy function IMHO for what
> you need. Why don't use GetDC(0)?

Cyril Margorin

More information about the wine-devel mailing list