LoadImage (4bpp) / CopyImage() crashing
bon at elektron.ikp.physik.tu-darmstadt.de
Sat Dec 10 05:44:48 CST 2005
>>>>> "Cyril" == Cyril Margorin <comargo at gmail.com> writes:
Cyril> 2005/12/10, Mike McCormack <mike at codeweavers.com>:
>> > Unfortunately, problem is that GetBitmapBits function in wine is >
>> incorrect, and may causes a buffer overflow, but the GetDIBits isn't.
>> Great. Then we need to fix it, not try avoid it.
Cyril> Yes, but I'm out of ideas how to fix it. The problem is that it
Cyril> takes in to account only physical pixmap (as it was called in
Cyril> x11drv/bitmap.c) but it should take pair physical pixmap/logical
Cyril> bitmap, and make pixels conversion from one to another.
If you look in the archives, you will see that I also stumbles about crashes
in CopyImage. My patches (by far not as elaborated as yours) where also not
applied. I also was out of ideas and hoped somebody else would pick up the
Uwe Bonnes bon at elektron.ikp.physik.tu-darmstadt.de
Institut fuer Kernphysik Schlossgartenstrasse 9 64289 Darmstadt
--------- Tel. 06151 162516 -------- Fax. 06151 164321 ----------
More information about the wine-devel