[mscms/tests/profile.c] Add another possible error
saulius2 at ar.fi.lt
Thu Dec 15 04:35:00 CST 2005
* On Wed, 14 Dec 2005, Paul Vriens wrote:
> GetStandardColorSpaceProfileW with a non-NULL machinename will return
> ERROR_NOT_SUPPORTED on 2000/WinXP/2003 (and maybe more).
> --- a/dlls/mscms/tests/profile.c
> +++ b/dlls/mscms/tests/profile.c
> @@ -515,7 +515,7 @@ static void test_GetStandardColorSpacePr
> /* Parameter checks */
> - fail_GSCSPW(machineW, 0, newprofile, &size, 0, (GLE == ERROR_INVALID_PARAMETER));
> + fail_GSCSPW(machineW, 0, newprofile, &size, 0, (GLE == ERROR_INVALID_PARAMETER || GLE == ERROR_NOT_SUPPORTED));
Hm, while I believe you, Paul, I don't like testing of several invalid
parameters in one check. If different versions of mscms.dll are coded in
different ways, we'll be getting one GLE on one platforms and another GLE
IMHO this way we can test algorithmic (conditional) branching of
GetStandardColorSpaceProfile(), which won't be the same on all platforms.
So I offer to skip it and test only single parameter in one check. I'll
try to send a patch.
More information about the wine-devel