SHELL32: cleanup, create unicode versions of some functions
Dmitry Timoshkov
dmitry at baikal.ru
Mon Feb 21 23:03:25 CST 2005
"Mike McCormack" <mike at codeweavers.com> wrote:
> ChangeLog:
> * cleanup, create unicode versions of _ILCreateFromPath,
> _ILCreateGuidFromStr, and _ILCreateFromFindData
> @@ -524,7 +516,7 @@ BOOL WINAPI ILIsEqual(LPCITEMIDLIST pidl
> _ILSimpleGetText(pidltemp1, szData1, MAX_PATH);
> _ILSimpleGetText(pidltemp2, szData2, MAX_PATH);
>
> - if (strcasecmp ( szData1, szData2 )!=0 )
> + if (strcasecmp( szData1, szData2 ))
> return FALSE;
>
> pidltemp1 = ILGetNext(pidltemp1);
> @@ -574,7 +566,7 @@ BOOL WINAPI ILIsParent(LPCITEMIDLIST pid
> _ILSimpleGetText(pParent, szData1, MAX_PATH);
> _ILSimpleGetText(pChild, szData2, MAX_PATH);
>
> - if (strcasecmp ( szData1, szData2 )!=0 )
> + if (strcasecmp( szData1, szData2 ))
> return FALSE;
As a common rule strcasecmp should never be used in Wine code, since
it introduces problem with portability and unexpected side effects
when locale of the underlying system differs from a Wine one.
You could make it a part of your clean up as well :-)
--
Dmitry.
More information about the wine-devel
mailing list