Use Interlocked* functions

Mike Hearn mike at navi.cx
Mon Jan 10 11:19:50 CST 2005


On Mon, 10 Jan 2005 18:03:30 +0100, Joris Huizer wrote:
> Paul Vriens was posting patches in which references to This->ref in 
> TRACE calls were replaced by a variable containing the value of 
> This->ref - I can't remember why this was necessary, but I don't think 
> he's doing it just for the fun of it

Right, in the case where you do this:

DWORD refs = InterlockedDecrement(&This->refs);

TRACE("refcount is now %d\n", This->refs);

that's clearly wrong, it should be refs in the second line. 
But refcounts are dumped all over the place, I have a feeling that grep
will give a *lot* of false positives ....




More information about the wine-devel mailing list