Janitorial : check all refcounts in Wine?

Paul Vriens paul.vriens at xs4all.nl
Wed Jan 12 07:42:53 CST 2005


for the described Janitorial task 'Use Interlocked functions in AddRef and
Release methods' I'm currently looking at This->ref.

If I however do a wider search I find a bit more, for example:

kernel/atom.c:256:               entryPtr->refCount++;
msi/handle.c:188:                ret = info->refcount--;
rpcrt4/cproxy.c:219:             This->RefCount++;
setupapi/virtcopy.c:106:         vhstrlist[n]->refcount++;

and so on. I only looked at names containing 'ref'. But there are more
around where 'ref' is not in the name:

ole32/compobj.c:                 COM_CurrentInfo()->inits++;

I know it's a hell of a job, but should these also be 'fixed'/changed?
Of course it's a bit hard to tell which are thread unsafe.



More information about the wine-devel mailing list