Re; cleanup shlfileop.c: why does this fail?

Rolf Kalbermatter rolf.kalbermatter at
Tue Jan 18 16:55:42 CST 2005

Joris Huizer wrote:

>That line can be removed as
>nFileOp = *(lpFileOp)
>on the first line - the variable is never changed after that (yeah, if 
>we really like, we could get rid of it)
>I hadn't removed it just like that, yet - but as it is useless, it can 
>be removed.

I wouldn't do that! This first line does not just copy a pointer but the
ENTIRE structure. And those parameters are sometimes overwritten inside
the function. So this last line also does do something, namely copying
the aborted state back into the main structure for reference by the caller.

Rolf Kalbermatter

More information about the wine-devel mailing list