load_VDMX - is the check for bCharSet == -1 necessary?

Huw D M Davies h.davies1 at physics.ox.ac.uk
Fri Jan 21 05:22:11 CST 2005

On Fri, Jan 21, 2005 at 03:49:33PM +1100, Troy Rollo wrote:
> In dlls/gdi/freetype.c, load_VDMX refuses to process ratio records in which 
> bCharSet is 0. Looking at the meaning of bCharSet and the layout of the VDMX 
> table <http://www.microsoft.com/OpenType/OTSpec/vdmx.htm>, I can see no 
> rational reason for this, and no reason appears in the code.
> Since 13th December this has been generating a FIXME message for some fonts.
> Does anybody know of a reason why this check is necessary? Commenting it 
> hasn't hurt anything obvious.

I think you can safely remove that if() statement.  Feel free to submit
a patch.

Huw Davies
huw at codeweavers.com

More information about the wine-devel mailing list