Refcounting in dsound

Mike Hearn mh at codeweavers.com
Mon Jan 24 12:49:55 CST 2005


On Mon, 24 Jan 2005 15:42:34 +0100, Paul Vriens wrote:
> wine/server/object.c:    obj->refcount++;
> wine/server/object.c:    if (!--obj->refcount)

No. The wineserver is not multithreaded.
 
> and in dll's:
> 
> advapi32/crypt.c:       pProv->refcount++;
> advapi32/crypt.c:       pProv->refcount--;
> advapi32/service.c:    if (--hdr->ref_count)

Not sure, maybe. There's no context to these, you really do have to read
the code and MSDN to figure out whether it needs to be thread safe or not.

> msi/table.c:    table->ref_count --;
> msi/table.c:        if ( --t->ref_count )
> msi/table.c:        (*ptable)->ref_count++;
> msi/table.c:    (*ptable)->ref_count++;
> 
> Mike about msi:
> ====
> I don't think so, handles are not COM objects and making MSI thread safe
> (if it's not already) should be some other Janitorial task.
> ===

I'd leave MSI to Mike and Aric at the moment.

thanks -mike




More information about the wine-devel mailing list