msi: use SourceLIst Functions

Mike McCormack mike at codeweavers.com
Tue Jul 12 10:02:53 CDT 2005


Aric Stewart wrote:

> +    MsiSourceListGetInfoW(szProduct, NULL, MSIINSTALLCONTEXT_USERMANAGED, 
> +            MSICODE_PRODUCT, INSTALLPROPERTY_LASTUSEDSOURCEstringW, sourcepath,
> +            &sz);

Hi Aric,

Seeing that you've gone to the trouble to define 
INSTALLPROPERTY_LASTUSEDSOURCE(A/W) in msi.h, which not use that define, 
rather than a non-standard one suffixed with stringW ?

The definition of INSTALLPROPERTY_LASTUSEDSOURCE means that a number of 
static string will be created everywhere msi.h is included.  There's a 
little bit more complicated but slightly better way of doing this used 
elsewhere in Wine, (eg. definition of STATUSCLASSNAME in 
include/commctrl.h).  Could you please update the strings defined in 
msi.h like those?

thanks,

Mike



More information about the wine-devel mailing list