[PATCH] FCI work for cabinet.dll [cabinet-fci-patch-02b.diff]
speeddymon at gmail.com
Sun Jun 12 10:46:40 CDT 2005
OHHH.. Boy do I feel a lil silly now. I was thinking it was pretty much
a steadfast rule, but that if someone felt strongly about their
indentation style, we would still accept their patch so that we could
get more functionality, and at the same time encourage them to submit
more.. Guess I was wrong. Sorry everyone for my (almost) flame..
Dimi Paun wrote:
> On Sat, 2005-06-11 at 21:55 -0500, Dustin Navea wrote:
>>Ok, Now I am getting fed up with all this petty bickering over indent
>>amounts. Alexandre wants 4 space indents. As soon as I get Linux
>>installed on my box, I'm going to _MANUALLY_ go through every single
>>file and make sure that we have 4 space indent, since I wouldnt know
>>how to write up a script to do it automatically.
> Don't worry about it: many people prefer 4 space indents, but Alexandre
> has made it clear that the developer is free to pick whatever indent
> they like for new code. So he's not going to accept patches that just
> reindent stuff, and rightfully so.
> Now, a lot of people don't feel strongly about it, and we just have a
> recommendation that 4-space indent is used to make it pleasant for
> others to work with that code as well. If the developer however feels
> very strongly about it, then they can choose whatever makes them happy
> (within reason, of course).
More information about the wine-devel