[PATCH] FCI work for cabinet.dll [cabinet-fci-patch-02c.diff]

Alexandre Julliard julliard at winehq.org
Mon Jun 20 10:46:11 CDT 2005

"Gerold J. Wucherpfennig" <gjwucherpfennig at gmx.net> writes:

> Please apply, it seems to be fine, so far.
> There is still some work to be done:
> - currently no support for big-endian machines
> - the ERF error structure aren't used on error
> - no real compression yet
> - unknown behaviour if files>4GB or cabinet >4GB
> - incorrect status information
> - check if the maximum size for a cabinet is too small to store any data
> - call pfnfcignc on exactly the same position as MS FCIAddFile in every case

You should get rid of all the PFCI_INT macro uses, that's making the
code really ugly and hard to read. You should do the cast once at the
start of the function (preferably as part of the handle validation
routine) and then pass around a pointer of the appropriate type.

Alexandre Julliard
julliard at winehq.org

More information about the wine-devel mailing list