dlls/ntdll/cdrom.c breakage

Gerald Pfeifer gerald at pfeifer.com
Tue Jun 28 13:55:19 CDT 2005

The following change to dlls/ntdll/cdrom.c 

  revision 1.57
  date: 2005/06/27 12:07:49;  author: julliard;  state: Exp;  lines: +13 -19
  Dmitry Timoshkov <dmitry at codeweavers.com>
  Add a check for sg_io_hdr_t and (not tested) check for scsireq_t

breaks on FreeBSD

  cdrom.c: In function `CDROM_ScsiPassThroughDirect':
  cdrom.c:1419: error: invalid application of `sizeof' to an incomplete type
  cdrom.c:1411: warning: unused variable `io'
  cdrom.c: In function `CDROM_ScsiPassThrough':
  cdrom.c:1534: error: invalid application of `sizeof' to an incomplete type
  cdrom.c:1526: warning: unused variable `io'

which does not have struct request_sense, but does have struct 
scsi_request_sense in /usr/include/cam/scsi/scsi_all.h.

I would have tried to cobble up a patch guard these by #ifdef linux,
but I'm not sure whether the patch to cdrom.c really was correct as
it currently looks: defining struct linux_cdrom_generic_command in
cdrom.c seems like quite bad a hack, doesn't it?


More information about the wine-devel mailing list