Fix libGL.a check on configure
andersonlizardo at yahoo.com.br
Wed Jun 29 19:11:36 CDT 2005
-----BEGIN PGP SIGNED MESSAGE-----
Alexandre Julliard wrote:
> It would be much better to try the actual linking and see what
Indeed, I was thinking on that myself... Why we just don't remove this
(incorrect IMHO) file presence check and let autoconf do the check
itself, which it already does as evidenced on the following snippet from
dnl Check for the presence of the library
$X_LIBS -lXext -lX11 -lm $X_EXTRA_LIBS)
Additionally, looking at the commit message that added the "test -e" check:
Changelog: Check for common broken nVidia+Mesa OpenGL library setups.
The current "test" check definitely does not ensure the system doesn't
have this "broken" setup. As you said, it should be better to let
autoconf do the check properly with AC_CHECK_LIB.
So here goes my latest patch which incorporates your suggestion (it just
removes the broken check). I've tested it with both NVidia libraries
(nvidia-glx and nvidia-glx-dev on Ubuntu 5.04) and Mesa "pure"
libraries, and wine compiled with OpenGL on both setups. For tests, I've
make -C dlls/ddraw/tests/ test
Although I'm not sure this is the ideal test to check if OpenGL is
working with Wine.
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.2.5 (GNU/Linux)
-----END PGP SIGNATURE-----
-------------- next part --------------
A non-text attachment was scrubbed...
Size: 1723 bytes
Desc: not available
Url : http://www.winehq.org/pipermail/wine-devel/attachments/20050629/9993cd98/wine-cvs-fix_libgl_check.bin
More information about the wine-devel