[winedbg] Get expressions working again.

Oliver Stieber oliver_stieber at yahoo.co.uk
Wed Mar 2 08:17:19 CST 2005

 --- Pouech Eric DMI AEI CAEN <pouech-eric at wanadoo.fr>
> I don't think this patch should go in as it is:
> - I don't think it's a good idea to have two ways to
> express a pointer type in the debugger (one being
> the standard dbghelp's SymTagPointerType, the other
> one the new deref count you've introduced). It would
> be better to add dynamic winedbg types (in the
> contrary to the static one's we already use
> dbg_itype_*), when we cannot find one in a module.

Ok, I don't think I'll do this I don't have time to
fix types_find_pointer and everywhere else to support
module=0 properly.

> - the returned string (for internal types' name)
> should be HeapAllocate:d, not a static buffer
> - please, use the current style for parenthesis,
> braces... and don't add a new one

Ok, I'll take a look at this, but if where shouldn't
be using two pointer types we should be using
SymGetTypeInfo in all cases?
> A+

Send instant messages to your online friends http://uk.messenger.yahoo.com 

More information about the wine-devel mailing list