urlmon/umon.c: Fix corruption

Jacek Caban jack at itma.pwr.wroc.pl
Sun May 22 13:00:39 CDT 2005


Uwe Bonnes wrote:

>Changelog:
>	dlls/urlmon/umon.c: URLMonikerImpl_Release()
>	Release structure elements before Freeing structure
>  
>
My patch I sent today fixes this too.

> Changelog:
> 	wine/dlls/urlmon/umon.c:URLMonikerImpl_BindToStorage()
>	Don't use a HeapAllocated pointer for other purposes

...

> +                if (path)
> +		    HeapFree(GetProcessHeap(), 0, path);

You don't need this check.


> Changelog:
> 	dlls/wininet/internet.c: CrackURL, dlls/wininet/tests/http.c
> 	Add some escape/unescape cases and code thor that cases
...
> +  ok(InternetCrackUrlA(TEST_URL3, 0, ICU_DECODE, &urlComponents),"InternetCrackUrl failed with GLE 0x%lx\n",GetLastError());
> +  fprintf(stderr,"BON:%*s\n", (int)urlComponents.dwUrlPathLength, urlComponents.lpszUrlPath);
>  
>  }

You shouldn't use fprintf() here. Use trace() instead.

Jacek




More information about the wine-devel mailing list