[ddraw] Mipmap creation with DDSCAPS_COMPLEX, DDSCAPS_MIPMAP, and no mipmap count

Antoine Chavasse a.chavasse at gmail.com
Sun May 29 14:10:08 CDT 2005

Mike Hearn <mh at codeweavers.com> wrote:
> I can't comment on the DirectX side of things, but this looks like a
> textbook case of how to do a patch correct.

Thanks :)

On 5/29/05, Lionel Ulmer <lionel.ulmer at free.fr> wrote:

> The only (minor) gripe I would have with this patch is the use of the 'log()
> / log()' to compute the mipmap count (I usually dislike floating point match
> - it's maybe my background in embedded programming where FPU are inexistant
> :-) )... I would have found it simpler to just have a 'while (min > 0) { min
> >>= 1; count += 1 }'.

Alright. I'll resend the patch with this change.

More information about the wine-devel mailing list