[advpack/setupapi] LaunchINFSection

Raphael fenix at club-internet.fr
Sun Nov 20 19:25:24 CST 2005


> I appreciate your work on advpack, but some comments that might help
> get it accepted more easily:
> * separate the patch into as many independent chunks as you can.  It
> seems like each function you implement can be sent in separate and
> linearly.

but as they are really small changes i keep on patch for that

> * it would help to add test cases wherever you can even if it's just
> to check how the function handles parameters.

I have started to think about that but need a complex test to test all 
capabilities (ie other than parse of command line)
(see answer to Markus)

> > +    if (!bRet) {
> >
> > +      ERR("Failed to CopyFileW(%s, %s)\n", debugstr_w(src),
> > debugstr_w(dst));
> >
> > +    }
> The rest of the file uses standard C indentation, so it's best to
> stick with that:

forget to change that, good catch :)

> --
> James Hawkins

-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 189 bytes
Desc: not available
Url : http://www.winehq.org/pipermail/wine-devel/attachments/20051121/5326f060/attachment.pgp

More information about the wine-devel mailing list