[advpack/setupapi] LaunchINFSection

Raphael fenix at club-internet.fr
Sun Nov 20 19:27:06 CST 2005


On Thursday 17 November 2005 01:59, Dimi Paun wrote:
> On Wed, 2005-11-16 at 23:56 +0100, Raphael wrote:
> > +    if (!bRet) {
> > +      ERR("Failed to CopyFileW(%s, %s)\n", debugstr_w(src),
> > debugstr_w(dst));
> > +    }
>
> You shouldn't issue ERR if the function can deal with
> the error condition. Just return the appropriate error
> code. ERR is to signal a case that should NEVER happen.
> This is not the case in any of the instances where you
> used ERR in this patch.

because the code who use this CopyFile is an hack.
And when CopyFile fail it revelant that we have a sequence problem 
So i keep it.

Regards,
Raphael
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 189 bytes
Desc: not available
Url : http://www.winehq.org/pipermail/wine-devel/attachments/20051121/44301858/attachment.pgp


More information about the wine-devel mailing list