WINE Regression due to patch applied Feb 22, 2005 10:50 CDT

[Mike McCormack]

James Hawkins wrote:

>>I found WINE's ability to run the application was broken between 20050222
>>10:50:10 CDT and 20050222 10:50:15 CDT. Watching the output of 'cvs update',
>>it seems three files were modified during these five seconds:

> Log message:
>        Mike McCormack <mike at codeweavers.com>
>        Make lstr* functions inline inside Wine.

This patch means that internally in Wine, there's no exception handlers 
around the lstr* functions, so passing a invalid pointer to a lstrcpyW 
(for example) will crash (and so it should).

KeyNote is causing a NULL pointer to be used with one of the lstr* 
functions in Wine, and this is causing the crash.

I tried installing KeyNote, and it seems to have a richedit problem... 
it crashes in EM_GETTEXTRANGE around line 1579 in editor.c... making the 
  allocation at line 1573 bigger seems to solve that.

Following that, it fails when trying to create directories:

000b:Call kernel32.CreateDirectoryA(7f0d5740 "C:\\Program 
Files\\KeyNote",00000000) ret=0043ab97
000b:Ret  kernel32.CreateDirectoryA() retval=00000001 ret=0043ab97
000b:Call kernel32.SetErrorMode(00000001) ret=00422fa1
000b:Ret  kernel32.SetErrorMode() retval=00000000 ret=00422fa1
000b:Call kernel32.GetFileAttributesA(7f0e573c "C:\\Program 
Files\\KeyNote") ret=00422fca
000b:Ret  kernel32.GetFileAttributesA() retval=00000010 ret=00422fca

...

000b:Call kernel32.CreateFileA(7fbcf6f0 "C:\\Program 
Files\\KeyNote",c0000000,00000000,00000000,00000002,000
00080,00000000) ret=00404820
000b:Ret  kernel32.CreateFileA() retval=ffffffff ret=00404820
000b:Call kernel32.GetLastError() ret=0040485a
000b:Ret  kernel32.GetLastError() retval=00000005 ret=0040485a
000b:Call user32.LoadStringA(00400000,0000ff8c,7fbcf250,00000400) 
ret=0040613e
000b:Ret  user32.LoadStringA() retval=00000012 ret=0040613e
000b:Call kernel32.RaiseException(0eedface,00000001,00000007,7fbcf684) 
ret=0043df7d

Don't know what it's expecting to happen there...

Anyway, if you send me a backtrace of where it's crashing when you try 
start it up, it should be easy enough to fix...

Mike