http://cvs.winehq.org/patch.py?id=19897 (shlfolder.c test)

Saulius Krasuckas saulius2 at ar.fi.lt
Sat Sep 3 13:23:32 CDT 2005


* On Sat, 3 Sep 2005, Filip Navara wrote:
> * Saulius Krasuckas wrote:
> > 
> >     /* This test shows that Windows doesn't allocate a new pidlLast, but returns a pointer into      
> >      * pidlTestFile (In accordance with MSDN). */
> > -    todo_wine{ok (ILFindLastID(pidlTestFile) == pidlLast, 
> > +    todo_wine{ok (pILFindLastID(pidlTestFile) == pidlLast,
> >         "SHBindToParent doesn't return the last id of the pidl param!\n");}
> 
> It would be wise to check if pILFindLastID != NULL.

Yeah, it would be, but then I need to think about where the check should 
reside: there or in the init-block?  If in the latter, then after this 
code gets executed:

  pILFindLastID = (void *)GetProcAddress(hShell32, (LPCSTR)16);

... I doubt we still were receiving NULL.



More information about the wine-devel mailing list