Suggestions for improvement of the emulator

Robert Lunnon bobl at
Wed Sep 7 12:55:51 CDT 2005

On Wednesday 07 September 2005 19:35, Alexandre Julliard wrote:
> Francois Gouget <fgouget at> writes:
> > Yeah, maybe a very generic 'Needs review' email to wine-devel would be
> > enough. It would also be the clue to the other Wine developpers:
> >  * that you're not going to be duplicating Alexandre's work if you
> >    review this patch
> >  * to look at the patch, dissect it to see what is wrong
> >  * if it is in your domain of competence and it looks good, post an
> >    approval message
> >  * to test the patch
> >  * and help its author get it accepted
> That should really be the default behavior, all patches need review;
> there's no reason to wait until I have looked at a patch to look at
> it. If you see a patch in an area that you know anything about, please
> review it, don't wait to see my reaction first.

There is a problem here, you are presupposing the submitter is interested in 
reviewing the patch to the projects specification. This subverts the value of 
collective development if the submitter is unwilling then you lose the value 
of the improvement AND potentially the developer.

It would be better to commit it to a branch to open it up to all to consider.

More information about the wine-devel mailing list