appdb developers please read

James Hawkins truiken at
Thu Sep 8 12:26:17 CDT 2005

On 9/8/05, Tom Wickline <twickline at> wrote:
> 1) send a patch
> 2) wait five days for a commit
> 3) re-submit after five days has passed
> 4) if the patch still isn't committed after two days ask why.

7 days is a long time to wait for an explanation of why a patch wasn't
committed.  I usually wait a day, resubmit the patch asking why it
wasn't accepted.  One of the biggest problems we have is one of
responsibility.  It's easy to become dependent on Alexandre to tell us
why each of our patches is not acceptable (I'm guilty of this too). 
More responsibility should be shifted from Alexandre to the developers
when it comes to examining submitted patches.  If a patch is not
accepted, the developer that sent the patch in (and even other
developers) should review the patch and try to see what is wrong with
it.  Put yourself in Alexandre's shoes and think why he would reject
it.  Granted it isn't always possible to know why a patch was rejected
(design issue maybe), but if more time was spent reviewing our own
patches (before and after submission), I don't think this would be as
big of an issue.  You have to keep in mind that Alexandre has a lot
more work to do then reviewing and committing patches, and it isn't
his job to make our patches correct.

James Hawkins

More information about the wine-devel mailing list