Need help debugging a memory corruption bug in shfldr_unixfs.c

[Phil Krylov]

On Fri, 9 Sep 2005 15:09:24 -0400
"Dimi Paun" <dimi at lattica.com> wrote:

> From: "Phil Krylov" <phil at newstar.rinet.ru>
> > OK, should we then make a patch which adds an IsWindow() check after every
> > notification in every control? This one fixes a really annoying bug, while
> > the other places are not proved to crash.
> 
> Well, if it's a entire class of bugs, we should fix them all.

I think that we should check if it's a class of bugs or a single bug first.

> I guess we need a bit of experimentation on windows to see
> if we need to protect all notifications or only a few ones.

> I guess we can protect all of them, in which case we have
> to look to see how we can do it centrally, in the notification
> function itself.

I don't see a way to do it clean enough.

So, here's a new version of the patch (enhanced comment, WARN changed to a
TRACE).


ChangeLog:

Protect against wrong memory access if a listview is destroyed during
processing of its NM_DBLCLK notification (a.k.a. file dialog GPF).

-- Ph.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: listview.patch
Type: text/x-patch
Size: 1303 bytes
Desc: not available
Url : http://www.winehq.org/pipermail/wine-devel/attachments/20050913/8a159cb6/listview.patch