OLEAUT32: add full multiplication/division support for DECIMAL, with tests

Alex Villací­s Lasso a_villacis at palosanto.com
Tue Sep 20 10:50:55 CDT 2005

Vijay Kiran Kamuju wrote:

>Hi Alex,
>I think your VarBstrFromDec fails with my testcases, 
>and you should not hardcode the decimal format seperator.
>And your patch fails my tests.
>Check my patch<http://www.winehq.org/pipermail/wine-patches/2005-September/020777.html>for
>VarBstrFromDec(for my implementation and tests), my implementation is
>You did a gr8 job implemeting the DECIMAL stuff in oleaut32.
>I have been sending and resending my patch since a month.
>I hope yours gets commited soon.
I guess the failing part is the one where the decimal separator is 
supposed to change between locales, but doesn't. My patch was based on 
the (mistaken) assumption that the VARIANT_MakeBstr() function would 
take care of the decimal separator for each locale. I will add your 
tests to my patch and resubmit with the necessary changes tomorrow.

As for sending the patch over and over in the month, I was sitting on 
mine because I tried to send it during three months and wasn't accepted. 
I assumed that it was because I failed to provide testcases.

Alex Villacís Lasso

More information about the wine-devel mailing list