Protect some DIB functions from bad inputs.

Vitaly Lipatov lav at etersoft.ru
Wed Apr 12 11:41:24 CDT 2006


В сообщении от 12 апреля 2006 15:17 Mike McCormack написал(a):
> Vitaly Lipatov wrote:
> > В сообщении от 12 апреля 2006 14:18 Alexandre Julliard написал(a):
> >>IsBadReadPtr is broken and should never be used. You need to add an
> >>exception handler around the actual access.
> >
> > I know many MS's dlls use IsBadReadPtr for check pointers.
> > IsBadReadPtr is malfunction conceptually or it is not realized correctly
> > yet?
>
> Something about it here:
>
> http://blogs.msdn.com/oldnewthing/archive/2006/01/17/513779.aspx
>
> It also has a race condition.  A thread could unmap the memory your
> checked after you checked it and before you try to read it.
>
> Mike
Thanks for the link. I read it out and found message about change IsBadReadPtr 
behaviour in Windows Vista:
http://blogs.msdn.com/wndp/archive/2005/08/18/453124.aspx

Will we simplify IsBadReadPtr also?
I saw IsBadReadPtr is used in native OLE implementation. We have not to use it 
in our realization of OLE?
Well, I see: 
> > В сообщении от 12 апреля 2006 14:18 Alexandre Julliard написал(a):
> >>IsBadReadPtr is broken 
OK.

-- 
Vitaly Lipatov, ALT Linux Team
Russia, Saint-Petersburg, www.etersoft.ru



More information about the wine-devel mailing list