patch feedback?

Alexandre Julliard julliard at winehq.org
Fri Aug 11 04:53:15 CDT 2006


Damjan Jovanovic <dj015 at yahoo.com> writes:

> +                classKey = SetupDiOpenClassRegKeyExW(&guid, KEY_ALL_ACCESS,
> +                     DIOCR_INSTALLER, NULL, NULL);
> +                /* wine does incorrectly return FALSE, so ... */
> +                ok(classKey != FALSE && classKey != INVALID_HANDLE_VALUE,
> +                    "failed opening class key, error %ld\n", GetLastError());

Tests are not supposed to cope with Wine bugs, that defeats the whole
purpose of the test. If returning FALSE is wrong then the test should
fail in that case.

-- 
Alexandre Julliard
julliard at winehq.org



More information about the wine-devel mailing list