winhelp: fix LZ77 decompressor patch: what's wrong?
Dan Kegel
dank at kegel.com
Fri Aug 11 09:09:56 CDT 2006
2006/8/11, HolyLich <lich at math.spbu.ru>:
> > Why not use memmove() instead?
>
> Heh, this problem was discussed before http://www.winehq.org/pipermail/wine-devel/2006-August/050133.html,
> http://www.winehq.org/pipermail/wine-devel/2006-August/050139.html
> http://www.winehq.org/pipermail/wine-devel/2006-August/050141.html.
>
> memmove cannot be used because it provides other functionality - it doesn't suit LZ77
> memcpy cannot be used because it's too clever (copies INTs instead of BYTEs),
Whether memmove copies one byte at a time or four makes no
difference. By bringing up this red herring you are muddying the issue
and probably convincing people you don't know what you're talking about.
You should replace the comment in your patch with one that
makes more sense.
- Dan
More information about the wine-devel
mailing list