gdi: resend add missing glyph code to GetGlyphIndices

Jeff Latimer lats at yless4u.com.au
Wed Aug 23 06:31:56 CDT 2006


Alexandre Julliard wrote:

>Jeff L <lats at yless4u.com.au> writes:
>  
>
>>+                /* Note that the call to GetTextMetricsW is made in the loop *
>>+                 * because it is less likely to have non existant glyphs     *
>>+                 * and hence we should have few calls to GetTextMetricsW as  *
>>+                 * a result                                                  */
>>+                GetTextMetricsW(hdc, &textm);
>>+                pgi[i] = textm.tmDefaultChar;
>>    
>>
>
>It's a good idea to not call GetTextMetrics unless you need it, but
>there's no reason to call it multiple times. It isn't hard to call it
>only the first time you need the default char.
>
>  
>
Alexandre, I can fix the multiple calls but I think I need to make the 
call unless there is another way.  Is making the call acceptable as in  
the updated patch?

Jeff
-------------- next part --------------
An HTML attachment was scrubbed...
URL: http://www.winehq.org/pipermail/wine-devel/attachments/20060823/e301b9c3/attachment.htm


More information about the wine-devel mailing list