ddraw: Fix warnings

Stefan Dösinger stefan at codeweavers.com
Fri Dec 15 05:59:36 CST 2006


Am Freitag 15 Dezember 2006 08:02 schrieb Dmitry Timoshkov:
> Hello,
>
> Changelog:
>     ddraw: Fix warnings.
>
> ---
>  dlls/ddraw/ddraw_thunks.c |    4 ++--
>  1 files changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/dlls/ddraw/ddraw_thunks.c b/dlls/ddraw/ddraw_thunks.c
> index ef8af6b..99518f0 100644
> --- a/dlls/ddraw/ddraw_thunks.c
> +++ b/dlls/ddraw/ddraw_thunks.c
> @@ -112,7 +112,7 @@ IDirectDraw3Impl_AddRef(LPDIRECTDRAW3 iface)
>      ICOM_THIS_FROM(IDirectDrawImpl, IDirectDraw3, iface);
>      ULONG ref = InterlockedIncrement(&This->ref4);
>
> -    TRACE("(%p) : incrementing IDirectDraw4 refcount from %lu.\n", This,
> ref -1); +    TRACE("(%p) : incrementing IDirectDraw4 refcount from %u.\n",
> This, ref -1);
Sorry I forgot to check your original patch for this, but did you check if the 
IDirectDraw3 refcount is bound to the IDirectDraw4 refcount? I'd suspect that 
the IDirectDraw3 interface has its own reference count too. See 
dlls/ddraw/tests/refcount.c

-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 189 bytes
Desc: not available
Url : http://www.winehq.org/pipermail/wine-devel/attachments/20061215/de8e1d8e/attachment.pgp


More information about the wine-devel mailing list