riched20: Implements FR_MATCHCASE for EM_FINDTEXT
leiz at ucla.edu
Fri Feb 24 12:48:47 CST 2006
On Friday 24 February 2006 04:39 am, Phil Krylov wrote:
> On Fri, 24 Feb 2006 12:24:45 +0100
> Alexandre Julliard <julliard at winehq.org> wrote:
> > Phil Krylov <phil at newstar.rinet.ru> writes:
> > > On Tue, 21 Feb 2006 14:08:38 -0800
> > >
> > > Lei Zhang <leiz at ucla.edu> wrote:
> > >> Hi Phil,
> > >>
> > >> Ya, it's a typo. Thanks for catching it.
> > >
> > > Could you kindly fix it then? As this patch was accepted unfixed.
> > I accepted the patch because I don't see how pCurItem could be NULL
> > in that loop (or rather, it could be NULL, but in that case we'll
> > crash before coming back to the loop test). Am I missing something?
> Yes, you're right. It can't be NULL because of an earlier test:
> para->member.para.nCharOfs + item->member.run.nCharOfs + nEnd - nLen
> >= nMin
> But this is very inevident.
> -- Ph.
Hi Phil, Alex
Yes, it can become NULL, here's how:
Inside while (ME_CharCompare(pCurItem->.... )
the last if() block assigns a new value to pCurItem, which may be NULL.
Sorry I didn't patch this earlier, I'll do it today.
More information about the wine-devel