shell32: Reimplement a factored SHFileOperation [RESEND 2]
Mike McCormack
mike at codeweavers.com
Fri Jan 6 21:29:45 CST 2006
James Hawkins wrote:
> Haven't received any comments yet. Is there anything wrong with this
> patch? I know it's large, but it can't be sent in pieces. The new
> implementation passes all the tests.
>
> Changelog:
> * Reimplement a factored SHFileOperation.
>
> dlls/shell32/shlfileop.c | 1131 +++++++++++++++++++---------------------
> dlls/shell32/tests/shlfileop.c | 242 ++-------
Hi James,
That's a lot of great work!
Try submit the tests first with todo_wine {} blocks around the stuff
that fails now, then submit a further change with your main patch that
shows with tests now pass.
That should reduce the size of your patch a little, and show how messed
up the old implementation of SHFileOperation is.
thanks,
Mike
More information about the wine-devel
mailing list