dlls/wined3d/device.c GetCreationParameters

Robert Shearman rob at codeweavers.com
Sun Jan 15 17:04:28 CST 2006


Al Tobey wrote:

> HRESULT  WINAPI  IWineD3DDeviceImpl_GetCreationParameters(IWineD3DDevice *iface, D3DDEVICE_CREATION_PARAMETERS *pParameters) {
>     IWineD3DDeviceImpl *This = (IWineD3DDeviceImpl *) iface;
>-
>-    FIXME("(%p) : stub\n", This);
>-    /* Setup some reasonable defaults */
>-    pParameters->AdapterOrdinal = 0; /* always for now */
>-    pParameters->DeviceType = D3DDEVTYPE_HAL; /* always for now */
>-    pParameters->hFocusWindow = 0;
>-    pParameters->BehaviorFlags =0;
>+    pParameters = &This->createParms;
>+    FIXME("(%p) : Partially implemented ... probably needs some checks\n", This);
>     return D3D_OK;
> }
>

This doesn't do what you think it does. pParameters is a local variable 
to assigning it to something won't affect what the caller sees. You 
probably want to use memcpy.

-- 
Rob Shearman




More information about the wine-devel mailing list