Unixfs as ShellFSFolder?

Michael Jung mjung at iss.tu-darmstadt.de
Tue Jan 17 10:44:35 CST 2006

Hi all,

I guess I'm responsible for a lot of redundant code between the 
implementations of filesystem shellfolders in shell32/shlfdr_fs.c and 
shfldr_unixfs.c. While I've always tried to re-use as much code as possible, 
unixfs by nature has to use posix apis to get hold of the unix filesystem.

In current cvs, unixfs can be used as a drop-in replacement for the old 
CLSID_ShellFSFolder implementation and if you apply the attached small patch, 
it will be. It would be nice if some people could try this in their local 
tree and report problems with it.

What do people think about getting rid of shfldr_fs.c in the long run, in 
order to remove the redundancy? Does ReactOS use wine's shell32.dll? I guess 
it would be a problem for them?

shell32: Use shfldr_unixfs CLSID_ShellFSFolder implementation instead of the 
one from shfldr_fs

 dlls/shell32/shellole.c |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)

Michael Jung
mjung at iss.tu-darmstadt.de
-------------- next part --------------
A non-text attachment was scrubbed...
Name: b4c74494324ef105c2ef224f7e4f24d0862ebb12.diff
Type: text/x-diff
Size: 545 bytes
Desc: not available
Url : http://www.winehq.org/pipermail/wine-devel/attachments/20060117/009a69f4/b4c74494324ef105c2ef224f7e4f24d0862ebb12.diff

More information about the wine-devel mailing list