[PATCH 1/2] kernel/tests: Implement safe local strcat function.
saulius2 at ar.fi.lt
Tue Jul 4 14:07:03 CDT 2006
* On Tue, 4 Jul 2006, Dmitry Timoshkov wrote:
> * "Saulius Krasuckas" wrote:
> > It was one "if" that I removed in my patch. Maybe you mean this way?
> Yes, that's a perfect way of checking for a possible buffer overflow,
> there is no need to complicate things.
It may be perfect from some POVs, but it creates some conditional
branching which I was thinking we're are trying to avoid in WRT suite,
for example branching used in checking for version-dependent stuff.
> strcat wrapper creates an illusion that it solves some problem when it
> actually doesn't.
So you agree there is a problem which isn't solved in current test code?
More information about the wine-devel