[AppDB] Re: appdb/include incl.php

[Jonathan Ernst]

Le jeudi 06 juillet 2006 à 21:36 -0500, WineHQ a écrit :
[...]
>  
> +/**
> + * rename $_REQUEST variables to preserve backwards compatibility
> + * with bugzilla links and urls in emails and on google from before our
> + * mass rename of GPC variables to use our coding standard prefixing
> + *
> + * NOTE: we may be able to remove these backwareds compatibility changes
> + *       in a few years, check in mid 2007 to see how many old
> + *       links are still poping up in google then
> + */
> +if(isset($_REQUEST['versionId']))
> +{
> +   $_REQUEST['iVersionId'] = $_REQUEST['versionId'];
> +   unset($_REQUEST['versionId']);
> +}
> +if(isset($_REQUEST['appId']))
> +{
> +   $_REQUEST['iAppId'] = $_REQUEST['appId'];
> +   unset($_REQUEST['appId']);
> +}

This (+catId) is enough IMHO, looking at the results of google when you
search for site:appdb.winehq.org, you'll see than only pages with catId,
versionId and appId are indexed and I can't think of any reason that
would make someone link to the AppDb with buglinkId or sub for example.

> +if(isset($_REQUEST['buglinkId']))
> +{
> +    $_REQUEST['iBuglinkId'] = $_REQUEST['buglinkId'];
> +    unset($_REQUEST['buglinkId']);
> +}
> +if(isset($_REQUEST['catId']))
> +{
> +    $_REQUEST['iCatId'] = $_REQUEST['catId'];
> +    unset($_REQUEST['catId']);
> +}
> +if(isset($_REQUEST['sub']))
> +{
> +    $_REQUEST['sSub'] = $_REQUEST['sub'];
> +    unset($_REQUEST['sub']);
> +}
> +if(isset($_REQUEST['topic']))
> +{
> +    $_REQUEST['sTopic'] = $_REQUEST['topic'];
> +    unset($_REQUEST['topic']);
> +}
> +/* End backwards compatibility code */
> +
> +
> +
>  // create arrays
>  $sidebar_func_list = array();
>  $help_list = array();
> 
> 
> 
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 189 bytes
Desc: Ceci est une partie de message
	=?ISO-8859-1?Q?num=E9riquement?= =?ISO-8859-1?Q?_sign=E9e?=
Url : http://www.winehq.org/pipermail/wine-devel/attachments/20060707/089d85ee/attachment.pgp