oleaut32: Adding a NULL to a safearray is supposed to crash
Robert Shearman
rob at codeweavers.com
Tue Jul 25 04:39:56 CDT 2006
Neil Skrypuch wrote:
>diff --git a/dlls/oleaut32/safearray.c b/dlls/oleaut32/safearray.c
>index 0eb92da..d3dd5e1 100644
>--- a/dlls/oleaut32/safearray.c
>+++ b/dlls/oleaut32/safearray.c
>@@ -843,12 +843,6 @@ HRESULT WINAPI SafeArrayPutElement(SAFEA
> if (!psa || !rgIndices)
> return E_INVALIDARG;
>
>- if (!pvData)
>- {
>- ERR("Invalid pvData would crash under Win32!\n");
>- return E_INVALIDARG;
>- }
>-
> hRet = SafeArrayLock(psa);
>
> if (SUCCEEDED(hRet))
>
>
This patch looks good to me and it fixes a number of installers.
--
Rob Shearman
More information about the wine-devel
mailing list