mapi32: Write-strings warnings fix
Peter Oberndorfer
kumbayo84 at arcor.de
Sat Jun 3 10:04:44 CDT 2006
On Saturday 03 June 2006 16:33, Andrew Talbot wrote:
> Changelog:
> mapi32: Write-strings warnings fix.
>
> diff -urN a/dlls/mapi32/sendmail.c b/dlls/mapi32/sendmail.c
> --- a/dlls/mapi32/sendmail.c 2006-05-23 17:24:40.000000000 +0100
> +++ b/dlls/mapi32/sendmail.c 2006-06-03 14:44:21.000000000 +0100
> @@ -113,8 +113,8 @@
> }
> if (message->nFileCount) FIXME("Ignoring attachments\n");
>
> - subject = message->lpszSubject ? message->lpszSubject : "";
> - body = message->lpszNoteText ? message->lpszNoteText : "";
> + subject = message->lpszSubject ? message->lpszSubject : NULL;
> + body = message->lpszNoteText ? message->lpszNoteText : NULL;
I think this is wrong, as it makes the whole "? :" construct unnecessary.
(for non NULL it evaluates to "message->lpszNoteText" and for NULL it becomes NULL;
>
> TRACE( "Subject: %s\n", debugstr_a(subject) );
> TRACE( "Body: %s\n", debugstr_a(body) );
>
>
>
Greetings Peter
More information about the wine-devel
mailing list